Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document browser compatibility #72

Closed
dvoytenko opened this issue Jan 28, 2018 · 7 comments
Closed

Document browser compatibility #72

dvoytenko opened this issue Jan 28, 2018 · 7 comments

Comments

@dvoytenko
Copy link

Could you please document the browser compatibility, in terms of major dependencies. E.g. is full ES2015 Proxy support required? Is there a way, when using a polyfill, to pre-enumerate known properties?

@surma
Copy link
Collaborator

surma commented Feb 26, 2018

I have added a list of compatible browsers (forgot to close this issue, sorry). I have not tested Comlink with a ES6 proxy polyfill. Might work, might not work.

@surma surma closed this as completed Feb 26, 2018
@adrianromanko
Copy link

@surma What would you say to converting this to using babel + core-js and lower the browser requirements?

@surma
Copy link
Collaborator

surma commented Mar 5, 2018

Is there a particular browser that you want to support? Because, as I said, the limiting factor is ES6 proxies, and support for that is looking fairly good!

screen shot 2018-03-05 at 8 25 09 pm

AFAIR, everything else is in Comlink fairly stable and old tech.

@adrianromanko
Copy link

Thanks.
I would like to get it down to Chrome version 43. Not sure if Proxies cannot be transpiled or polyfilled with ES5.

@surma
Copy link
Collaborator

surma commented Mar 5, 2018

There is a polyfill for proxies. If you want give it a try and let me know how it goes.

If I don’t have to mangle my code to make it work, I’m happy to support Chrome 43.

@adrianromanko
Copy link

Works with the Proxy polyfill.
es5 fork: https://github.com/adrianromanko/comlink

@surma
Copy link
Collaborator

surma commented Mar 5, 2018

Cooool! No further changes necessary? If so I’ll put a comment in the README :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants