-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to link to text #50
Comments
I do not get this issue on most websites but i do on a few I use. Can you try: 1 Go to https://www.bbc.co.uk/news 4 Repeat the above on THIS website https://theconversation.com/supply-chains-in-2022-shortages-will-continue-but-for-some-sellers-the-problem-will-be-too-much-stock-174085, again choosing an area of text. See the attached "Link test" doc, Test 2 containing the link which opens into the area of text. I repeated the above on several sites and most behaved as required. From all this I deduce that it is the coding of certain websites that allow / disallow "Link to Selected Text" to select certain areas, rather than a problem with the Extension itself. |
Thanks for putting together these tests. The generated links from the extension are correct. Could I ask you to file Chromium browser bugs for the ones that don't work? You can do so via new.crbug.com. Choose |
@tomayac That would be very difficult as it appears to be random sites, i.e. from above "BBC News" exhibits the issue, "The Conversation" does not. |
Since the BBC (probably) uses templates for their sites, a representative example of each problem would suffice. A common issue is changes on the site, either to the actual text, or the surrounding prefixes and/or suffixes that the extension uses to make the links unique. In simplified language, if you wanted to link to a specific instance of, say, the word "the", there would need to be a way to say which "the", since there are many "the"s on a typical English page. The extension then tries to find a unique occurrence, for example, the one "the" that is immediately followed by the word "example". If this word happens to change, the whole link doesn't work anymore. In the worst case, the word happens to be a dynamically changing word that changes for almost each load. There is no way for the extension to detect this. |
Exactly - I follow that explanation - thanks. As the list will never be complete, someone would need to go through dozens of websites to get a cross-section - I am not volunteering for that task - sorry! :-) I would respectfully suggest creating a bug that simply points at this one would be the most one could usefully do. In reality, it would seem to me that creating a new bug is pointless; rather this issue should go into Release Notes as a warning about a limitation of the extension. |
It's not a limitation of the extension, but of the feature per se, since it's based on live web pages and not archives. If you want to be sure a link works "forever", you can actually archive a page first, and then link to the archived version (example: https://web.archive.org/web/20220110093302/https://www.bbc.com/news/health-59909860#:~:text=is%20this%20nhs%20crisis%20really%20worse%20than%20ones%20before%3F). |
Which would be pretty pointless for most users I suggest. So in practical (User) terms it's a (perceived) limitation because the extension may not work as desired on live web pages, but is working as intended by the Dev. Once again to be mentioned in Release Notes rather than considered as a bug, IMO |
I have tried multiple times, but when I create a link to text the URL only goes to the page and not the text.
Is there some way to fix this?
The text was updated successfully, but these errors were encountered: