Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the container display the value of an env var if present #28

Closed
steren opened this issue Apr 7, 2020 · 4 comments
Closed

Make the container display the value of an env var if present #28

steren opened this issue Apr 7, 2020 · 4 comments

Comments

@steren
Copy link
Collaborator

steren commented Apr 7, 2020

Now that Cloud Run supports traffic splits, we often need a demo container ro demo blue/green deployment.

What I usually do is I take a go hello world that display the value of an env var (if present), and I set it to "blue" and "green" in two revisions for my demo.

It could be useful to have this container do the same, so that we don't even need to build one.

One word of the text could change based on this env var for example

@ahmetb
Copy link
Contributor

ahmetb commented Apr 7, 2020

If it helps showing blue/green deployments, we actively maintain:

  • gcr.io/google-samples/hello-app:1.0
  • gcr.io/google-samples/hello-app:2.0

which print different version numbers (hence indicating canary rollout).

@steren
Copy link
Collaborator Author

steren commented Apr 7, 2020

Good to know.

I still think it would help to show the concept of revision to be able to alter the page with an "quick and outside of the container" change.

No rush, I was just capturing a need I had this morning.

@marcjoha
Copy link

marcjoha commented Dec 2, 2020

+1 on this request. I demo these things randomly without much prep and I usually just grab the cloud-run-hello container because it's shown in the UI.

@steren
Copy link
Collaborator Author

steren commented Dec 5, 2020

PRs welcome, this change should be straightforward (the code already looks for some env vars)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants