Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoneg does not provide default configuration for max-rate-per-endpoint and max-connections-per-endpoint #104

Closed
agh95 opened this issue Oct 5, 2023 · 1 comment

Comments

@agh95
Copy link
Contributor

agh95 commented Oct 5, 2023

Autoneg requires setting max-rate-per-endpoint/max-connection-per-endpoint in the annotations. This property is a bit complex to understand and get right so as an infrastructure team we would like to abstract our users away from it. One way to do that is if autoneg provided config option to set default value for this setting.

@rosmo
Copy link
Collaborator

rosmo commented Oct 5, 2023

Having the defaults is fine, though I think it might prove to be quite difficult to set good defaults (as every application's traffic tolerance is different).

@rosmo rosmo closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants