spanner: various bug fixes + test coverage #2313

callmehiphop · 2017-05-16T15:44:45Z

Closes #2273
Closes #2197
Closes #2176

stephenplusplus

Some initial thoughts before I look at the tests.

packages/spanner/src/codec.js

+  }
+
+  var isSpecialNumber = is.infinite(field) ||
+    (typeof field === 'number' && isNaN(field));


packages/spanner/src/database.js

@@ -577,6 +593,25 @@ Database.prototype.run = function(query, options, callback) {
 *   .on('end', function() {});
 *
 * //-
+ * // If you need to enforce a specific param type, a types map can be provided.
+ * // This is typically useful if your param value can be null.


packages/spanner/src/database.js

+      var type = reqOpts.types[prop]
+      var child;
+
+      if (is.object(type)) {


packages/spanner/src/database.js


    for (var prop in reqOpts.params) {
      var field = reqOpts.params[prop];
+
+      if (!reqOpts.types[prop]) {


packages/spanner/src/table.js

@@ -347,10 +349,10 @@ Table.prototype.insert = function(keyVals, callback) {
 *     be yielded. If using a composite key, provide an array within this array.
 *     See the example below.
 * @param {string=} query.index - The name of an index on the table.
+ * @param {number} query.limit - The number of rows to return.


packages/spanner/system-test/spanner.js

+        .then(function() {
+          var promise = Promise.resolve();
+
+          for (var i = 0; i < 5; i++) {


packages/spanner/system-test/spanner.js

+      return database.create()
+        .then(onPromiseOperationComplete)
+        .then(function() {
+          return table.create(multiline.stripIndent(function() {/*


packages/spanner/src/transaction.js

+  var gaxOptions = reqOpts.gaxOptions;
+  delete reqOpts.gaxOptions;
+
+  config.method(reqOpts, gaxOptions, function(err, resp) {


packages/spanner/src/transaction.js

  var reqOpts = extend({
    session: this.session.formattedName_
  }, config.reqOpts);

  var gaxOptions = reqOpts.gaxOptions;
  delete reqOpts.gaxOptions;

-  return config.method(reqOpts, gaxOptions);
+  // return config.method(reqOpts, gaxOptions);


packages/spanner/src/transaction.js

+  requestStream.on('error', function(err) {
+    if (err.code !== ABORTED) {
+      userStream.emit('error', err);
+      return;


packages/spanner/src/database.js

- *   params: {
- *     name: 'Eddie Wilson'
+ *   sql: 'SELECT * FROM Singers WHERE name = @name AND id = @id',
+ *   params: {,


callmehiphop added 7 commits May 1, 2017 07:56

spanner: add more system tests

fdb3413

range support + read tests

719803a

add paramTypes support

36564d5

add query + param system tests

a8ca90d

system tests for inserting all the different data types

7c034c1

read only txn bug fixes + timestamp support

d68d3de

read only txn system tests

f06650e

callmehiphop added api: spanner Issues related to the Spanner API. status: do not merge labels May 16, 2017

callmehiphop requested review from stephenplusplus and vkedia May 16, 2017 15:44

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2017

stephenplusplus reviewed May 16, 2017

View reviewed changes

packages/spanner/system-test/spanner.js Outdated

.then(function() {

var promise = Promise.resolve();

for (var i = 0; i < 5; i++) {

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed May 16, 2017

View reviewed changes

packages/spanner/system-test/spanner.js

return database.create()

.then(onPromiseOperationComplete)

.then(function() {

return table.create(multiline.stripIndent(function() {/*

This comment was marked as spam.

Sign in to view

callmehiphop added 2 commits May 16, 2017 15:50

fixed several chunking bugs

dc0b9be

system tests for large reads/chunking

eaa204b

stephenplusplus mentioned this pull request May 16, 2017

Spanner - transaction.runStream : fails for large query results : Uncaught TypeError: Cannot read property 'rowType' of null #2273

Closed

callmehiphop added 3 commits May 18, 2017 12:14

refactored aborted error retry logic

2f5e9fc

system tests for read/write transactions

0ee32f6

lint/style fixes

bc1e7ad

callmehiphop removed the status: do not merge label May 18, 2017

callmehiphop commented May 18, 2017

View reviewed changes

stephenplusplus mentioned this pull request May 22, 2017

Spanner: Error: Session not found #2061

Closed

callmehiphop added 2 commits May 22, 2017 13:38

added retry on abort logic to txn streams

652f99f

small tweaks based on pr feedback

02c7c15

stephenplusplus reviewed May 23, 2017

View reviewed changes

small changes based on pr feedback

05d3348

stephenplusplus reviewed May 30, 2017

View reviewed changes

packages/spanner/src/database.js Outdated

* params: {

* name: 'Eddie Wilson'

* sql: 'SELECT * FROM Singers WHERE name = @name AND id = @id',

* params: {,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

remove rogue comma

ab5a1ca

stephenplusplus merged commit 563ec3b into googleapis:master May 31, 2017

This was referenced Jul 5, 2017

Update dependency @google-cloud/datastore to version 1.0.7 Platane/velib-paris#24

Merged

Update dependency @google-cloud/storage to version 1.2.0 Platane/velib-paris#25

Merged

spanner: various bug fixes + test coverage #2313

spanner: various bug fixes + test coverage #2313

Conversation

callmehiphop commented May 16, 2017 • edited Loading

stephenplusplus left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

callmehiphop commented May 16, 2017 •

edited

Loading