Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gRPC #135

Closed
rramkumar1 opened this issue Aug 11, 2020 · 7 comments
Closed

Support gRPC #135

rramkumar1 opened this issue Aug 11, 2020 · 7 comments
Assignees
@theemadnes

Comments

@rramkumar1
Copy link
Contributor

We should add gRPC support to the whereami binary (including support for the standard gRPC health check API)
@rramkumar1
Copy link
Contributor Author

@theemadnes

@theemadnes
Copy link
Member

good idea @rramkumar1 - i'll start planning this out

@theemadnes
Copy link
Member

@rramkumar1 re: health check API are you referring to this?

@rramkumar1
Copy link
Contributor Author

@theemadnes yep

@theemadnes theemadnes self-assigned this Sep 11, 2020
@theemadnes
Copy link
Member

@rramkumar1 in case you were still interested this is almost ready to go. code works - i just need to write docs and do PR. take a look here if you're interested. also the deployment spec reflects use of healthcheck API.

@theemadnes
Copy link
Member

#150

@theemadnes
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theemadnes theemadnes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theemadnes @rramkumar1