Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible wrong formatting or mistype in import google --help #55

Closed
Andor opened this issue May 10, 2019 · 5 comments
Closed

Possible wrong formatting or mistype in import google --help #55

Andor opened this issue May 10, 2019 · 5 comments

Comments

@Andor
Copy link

Andor commented May 10, 2019

Import current State to terraform configuration from google cloud

Usage:
   import google [flags]
   import google [command]

Available Commands:
  list        Import current State to terraform configuration

Flags:
  -b, --bucket string        gs://terraform-state
  -c, --connect               (default true)
  -f, --filter strings       google_compute_firewall=id1:id2:id4
  -h, --help                 help for google
  -o, --path-output string    (default "generated")
  -p, --path-patter string   {output}/{provider}/custom/{service}/ (default "{output}/{provider}/{service}/")
      --projects strings     
  -r, --resources strings    firewalls,networks
  -s, --state string         local or bucket (default "local")
  -z, --zone string

Use " import google [command] --help" for more information about a command.

--path-patter looks incorrect for me.
I suspect output format issue or just a simple mistype in the option name.

@Andor Andor changed the title Possible wrong formatting or mistype in --help Possible wrong formatting or mistype in import google --help May 10, 2019
@Andor
Copy link
Author

Andor commented May 10, 2019

As well list Import current State to terraform configuration looks incorrect for me.

@sergeylanzman
Copy link
Collaborator

Suggestions for other name or text?

@Andor
Copy link
Author

Andor commented May 10, 2019

I think it's just a mistype and it should be --path-pattern instead of --path-patter.

And the text for list command should be List supported resources for Google Cloud Platform:

$ terraformer import google --help
...
Available Commands:
  list        List supported resources for Google Cloud Platform

and:

$ terraformer import google list --help
Import current State to terraform configuration

Usage:
   import google list [flags]
...

@sergeylanzman
Copy link
Collaborator

yeah... look good.
Thank you!
Fixed in 9637a68

@Andor
Copy link
Author

Andor commented May 10, 2019

Nice job @sergeylanzman! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants