cr-syncer: Preserve observedGeneration semantics #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drigz
force-pushed
the
cr-syncer-generation
branch
from
79040f2
to
f376c8a
Compare
The status's observedGeneration field lets a CR creator identify when a controller has updated the status to reflect a change in the spec. However, because it's tied to the generation field, which is managed by the apiserver, it can't be directly copied between two clusters. Instead, we can preserve the difference between generation and observedGeneration, allowing the CR creator to wait until generation==observedGeneration before looking at the status.
drigz
force-pushed
the
cr-syncer-generation
branch
from
f376c8a
to
1038ce9
Compare
faximan
reviewed
Mar 29, 2023
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status's observedGeneration field lets a CR creator identify when a controller has updated the status to reflect a change in the spec. However, because it's tied to the generation field, which is managed by the apiserver, it can't be directly copied between two clusters. Instead, we can preserve the difference between generation and observedGeneration, allowing the CR creator to wait until generation==observedGeneration before looking at the status.
I also needed to bump to Go 1.18 to use
any.