Restart cr-syncer informers on too many subsequent conflict errors #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensonic
reviewed
Jul 30, 2021
ensonic
reviewed
Jul 30, 2021
|
Hi @ensonic, a friendly reminder |
|
I'm afraid Stefan is on vacation at the moment, but he'll be back later this week. Let me know if this is urgent and I can try to take over. |
|
thanks for notifying me. |
|
Ah, in that case, I think the answer is "some walks in the Austrian Alps" but Stefan can confirm :) |
|
that sounds good 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to this issue #64
When trying to run cloud-robotics with Istio ingresses I realised that is is hard to guarantee that no issues as in #64 happen again as long as client-go does not identify connection drops reliably.
One way to identify that a watcher died are many subsequent conflict errors when cr-syncers updates the remote cluster
This change restarts informers for one CRD in case 5 subsequent conflict errors occur. This is more efficient than restarting the whole cr-syncer because it could happen for single CRDs.