Fix robot chart in app CRD #81
Conversation
| @@ -36,7 +36,7 @@ spec: | |||
| type: string | |||
| inline: | |||
| type: string | |||
| robots: | |||
| robot: | |||
There was a problem hiding this comment.
In line 94 below it is also robots:
There was a problem hiding this comment.
I think robots (plural) is correct and also what we actually use everywhere
There was a problem hiding this comment.
Prometheus for example calls it prometheus-robot, if I understand the underlying bazel function correctly.
And the go type calls it robot too. That's why we call it robot in all our app charts.
There was a problem hiding this comment.
We use robot in App CRs since the beginning and it would be more effort to change it here.
In the end there was no other way to use the name of the Go structure and we just did not notice the inconsistency with App CRD specification from app-crd.yaml because CRDs in v1beta1 preserved unknown fields.
There was a problem hiding this comment.
RIght, this is for the app! Makes sense.
@ensonic there was one more little inconsistency between apps-crd.yaml and the go structure I did not find in the first place. It's just one letter, but in the end it removes all the robot charts from App CRs.