Add clusterroles and dedicated service accounts for app management apps / remove permissive binding #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cluster roles and for app-rollout and chart-assignment-controllers and starts them with dedicated service accounts. Additionally the permissive-binding is removed during deployment.
The cluster roles for app-rollout-controller are pretty easy and just include additional permissions for
robots
,apps
,approllouts
andchartassignments
CRDs.Chart-assignment-controller has now permissions for
chartassignments
andresourcesets
CRDs and for namespaces. For convenience thecluster-admin
role is assigned to its service account too, because we do not really have a concept yet, which Kubernetes objects we would like to be managed by chart-assignment-controller.However, this change allows to investigate roles and permissions of other apps now, which was somehow pointless while a permissive-binding was existing. Thus, this PR might lead to "permission denied" in other apps.