Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-style: add <a><paper-button> styling #51

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Commits on Apr 24, 2018

  1. step-style: add <a><paper-button> styling

    All this time we've had the following "download" paper-button structure
    on the official website at g.co/codelabs:
    
        <a href="..."><paper-button>download</paper-button></a>
    
    Note that this is in accordance with the Polymer 1.0 recommendation
    in https://elements.polymer-project.org/bower_components/paper-button/demo/index.html
    
    Unfortunately, this is not how codelab-components were styled all this
    time. A demo codelab has the inverse structure:
    
        <paper-button><a href="...">download</a></paper-button>
    
    Here's where it's used in codelab-components repo:
    https://github.com/googlecodelabs/codelab-components/blob/7397f708d210dfbb7348084033a32ba070ec4df4/demo/codelab.html#L74
    
    As a consequence, the styling Will provided in a recent change in
    f3e63d5
    used the latter structure. We never noticed the difference because
    before the styling refresh, the download button background and link
    colors were very close.
    Alex Vaghin committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    c22a15d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. demo: add paper-button wrapped in anchor example

    Alex Vaghin committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    1ce90fb View commit details
    Browse the repository at this point in the history