Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Updated to fix deployments - auth, hello and frontend #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IshanSinghal
Copy link

apiVersions were replaced with "apps/v1" and selectors were added.

apiVersion was outdated and selectors missing
apiVersion was outdated and selectors missing
apiVersion was outdated and selectors missing
@Siddhant-K-code
Copy link

Thanks for fixing #14

@Shashwatsingh22
Copy link

Shashwatsingh22 commented Oct 9, 2020

hello-canary.yaml

apiVersion: apps/v1
kind: Deployment
metadata:
name: hello-canary
spec:
replicas: 1
selector:
matchLabels:
app: hello

@kasunramkr
Copy link

apiVersions were replaced with "apps/v1" and selectors were added.

hello-canary.yaml also needs to be changed right?

@Shashwatsingh22
Copy link

Shashwatsingh22 commented Oct 12, 2020

apiVersions were replaced with "apps/v1" and selectors were added.

hello-canary.yaml also needs to be changed right?

Yes not only hello-canary.yaml also the hello-green.yaml... You see my pull request to!! #19

@kasunramkr
Copy link

apiVersions were replaced with "apps/v1" and selectors were added.

hello-canary.yaml also needs to be changed right?

Yes not only hello-canary.yml also the hello-green.yml... You see my pull request to!! #19

Thanks @Shashwatsingh22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants