Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove images and styles directory #4

Closed
petele opened this issue Mar 2, 2016 · 8 comments
Closed

Remove images and styles directory #4

petele opened this issue Mar 2, 2016 · 8 comments

Comments

@petele
Copy link
Collaborator

petele commented Mar 2, 2016

Remove the images and styles directory from the root of the project, the files all exist in the individual step-0x folders.

Let's hang off on this one until after IWD

@mco-gh
Copy link
Contributor

mco-gh commented Mar 3, 2016

I'm happy to do this now but if you'd prefer to wait for after IWD, I'm fine with that too. Will wait to hear from you, Pete.

@petele
Copy link
Collaborator Author

petele commented Mar 3, 2016

Let's wait until Monday, I don't want to dramatically delete files 2 days before the event! :)

@mco-gh
Copy link
Contributor

mco-gh commented Mar 3, 2016

sounds good. I did delete that other set of files in the related issue as you didn't express this concern but maybe I should restore those for safety?

@petele
Copy link
Collaborator Author

petele commented Mar 3, 2016

No, those I'm confident aren't needed, most of them were meant for the
pw-precache step or deploying to firebase.

On Thu, Mar 3, 2016 at 8:30 AM, Marc Cohen notifications@github.com wrote:

sounds good. I did delete that other set of files in the related issue as
you didn't express this concern but maybe I should restore those for safety?


Reply to this email directly or view it on GitHub
#4 (comment)
.

@mco-gh
Copy link
Contributor

mco-gh commented Mar 3, 2016

cool, thanks! I think we're all done with the repo.

On 3 March 2016 at 13:40, Pete LePage notifications@github.com wrote:

No, those I'm confident aren't needed, most of them were meant for the
pw-precache step or deploying to firebase.

On Thu, Mar 3, 2016 at 8:30 AM, Marc Cohen notifications@github.com
wrote:

sounds good. I did delete that other set of files in the related issue as
you didn't express this concern but maybe I should restore those for
safety?


Reply to this email directly or view it on GitHub
<
#4 (comment)

.


Reply to this email directly or view it on GitHub
#4 (comment)
.

Marc Cohen
mco@google.com
http://about.me/marc1

@mco-gh
Copy link
Contributor

mco-gh commented Mar 3, 2016

For now. :)

On 3 March 2016 at 14:24, Marc Cohen marccohen@google.com wrote:

cool, thanks! I think we're all done with the repo.

On 3 March 2016 at 13:40, Pete LePage notifications@github.com wrote:

No, those I'm confident aren't needed, most of them were meant for the
pw-precache step or deploying to firebase.

On Thu, Mar 3, 2016 at 8:30 AM, Marc Cohen notifications@github.com
wrote:

sounds good. I did delete that other set of files in the related issue
as
you didn't express this concern but maybe I should restore those for
safety?


Reply to this email directly or view it on GitHub
<
#4 (comment)

.


Reply to this email directly or view it on GitHub
#4 (comment)
.

Marc Cohen
mco@google.com
http://about.me/marc1

Marc Cohen
mco@google.com
http://about.me/marc1

@domenic
Copy link

domenic commented Mar 5, 2016

I did get confused by how much stuff was in the root when first unzipping

@petele
Copy link
Collaborator Author

petele commented Mar 5, 2016

It's been cleaned up and should be OK now. If not, please let me know asap!
On Mar 5, 2016 12:07 AM, "Domenic Denicola" notifications@github.com
wrote:

I did get confused by how much stuff was in the root when first unzipping


Reply to this email directly or view it on GitHub
#4 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants