Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for all examples #82

Closed
r2d4 opened this issue Feb 13, 2018 · 3 comments
Closed

Integration tests for all examples #82

r2d4 opened this issue Feb 13, 2018 · 3 comments
Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors meta/testing Issues focused on testing Skaffold itself

Comments

@r2d4
Copy link
Contributor

r2d4 commented Feb 13, 2018

All examples should be covered by integration tests. We should always keep examples up to date with new changes, and convey to the users clearly when there are breaking change. We can do this with release notes or config comments.
@r2d4 r2d4 added area/testing Issues concerning the testing phase of Skaffold help wanted We would love to have this done, but don't have the bandwidth, need help from contributors labels Feb 13, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jun 4, 2018

We're still missing bazel

@r2d4
Copy link
Contributor Author

r2d4 commented Jun 4, 2018

And some more

@r2d4
Copy link
Contributor Author

r2d4 commented Jun 6, 2018

Closing in favor of #441

@r2d4 r2d4 closed this as completed Jun 6, 2018
@nkubala nkubala added meta/testing Issues focused on testing Skaffold itself and removed area/testing Issues concerning the testing phase of Skaffold labels Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We would love to have this done, but don't have the bandwidth, need help from contributors meta/testing Issues focused on testing Skaffold itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2d4 @dlorenc @nkubala