Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with generate params and midi output params #1

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Fixed issue with generate params and midi output params #1

merged 1 commit into from
Nov 16, 2016

Conversation

camiblanch
Copy link
Contributor

Without this fix I was unable to get anything other than uncaught errors using python 2.7. Once I fixed the params, everything worked smoothly.

@gnestor
Copy link

gnestor commented Nov 16, 2016

This fixes #2 for me!

@andrew-c-edwards
Copy link

This gets the basic code to run, but if you try to use a different RNN you'll run into problems. See discussion in #2 . A better temp fix is to move third_party/magenta up a level to simply magenta ... In there, there is an implementation of generate that takes a GenerateSequenceRequest object.

@Hdooster
Copy link

@andrew-c-edwards your fix worked as well for me (2.7), thanks!

@tambien tambien merged commit 6a573d1 into googlecreativelab:master Nov 16, 2016
tambien added a commit that referenced this pull request Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants