Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

As of the 154.0.0 release of the Cloud SDK, datalab connect no longer works on Windows #1356

Closed
ojarjur opened this issue May 4, 2017 · 4 comments · Fixed by #1357
Closed
Assignees

Comments

@ojarjur
Copy link
Contributor

ojarjur commented May 4, 2017

It seems that with release 154.0.0, the gcloud compute ssh command took out the platform-specific sanitation that it performed on SSH flags.

Previously, passing in --ssh-flag=-o --ssh-flag=LogLevel=info was a no-op on Windows, as the gcloud command new to ignore the -o option since PuTTY does not support it.

As of the 154.0.0 release, however, this is no longer the case, and the -o flag is passed to PuTTY, which then fails saying it does not recognize that option.

The known work-arounds for this issue are:

  1. Downgrade to version 153.0.0 of the Cloud SDK, or
  2. Use the Cloud Shell to run datalab connect
@ojarjur ojarjur self-assigned this May 4, 2017
ojarjur added a commit that referenced this issue May 4, 2017
This change updates the `datalab` command line tool so that the
`-o` option to the `gcloud compute ssh` command is only passed
when running on Posix systems (e.g. Linux and Mac OS X).

This is necessary because some SSH clients (notably, PuTTY) do
not support that option, so passing it in can cause the SSH
client to error out.

This was not an issue prior to the 154.0.0 release of the Cloud SDK,
as earlier versions would filter out the `-o` flag when running on
Windows. However, with 154.0.0 that filtering has been removed and
the `-o` option is passed in as-is.

This fixes #1356
ojarjur added a commit that referenced this issue May 4, 2017
This change updates the `datalab` command line tool so that the
`-o` option to the `gcloud compute ssh` command is only passed
when running on Posix systems (e.g. Linux and Mac OS X).

This is necessary because some SSH clients (notably, PuTTY) do
not support that option, so passing it in can cause the SSH
client to error out.

This was not an issue prior to the 154.0.0 release of the Cloud SDK,
as earlier versions would filter out the `-o` flag when running on
Windows. However, with 154.0.0 that filtering has been removed and
the `-o` option is passed in as-is.

This fixes #1356
@ojarjur
Copy link
Contributor Author

ojarjur commented May 11, 2017

Version 155.0.0 of the Cloud SDK was released this morning, and that latest version includes the fix for this issue.

@TheOddler
Copy link

I'm getting a similar bug on Windows, but now Putty is complaining about the unknown options '-it'

image

Is this problem back? Or is this a different problem?

I'm running:

Google Cloud SDK 184.0.0
beta 2017.09.15
bq 2.0.28
core 2018.01.05
gsutil 4.28

And putty 0.70

@ojarjur
Copy link
Contributor Author

ojarjur commented Jan 16, 2018

@TheOddler No, I believe what you are seeing is a different issue.

It looks like what you are hitting is an issue with the gcloud compute ssh command's --container flag not working on windows. If you use datalab connect to connect to the instance, or gcloud compute ssh without the --container flag, then the issue should not reproduce.

If that is correct (i.e. you try those other two commands and they work), then please file a bug against the Cloud SDK using this link.

@TheOddler
Copy link

TheOddler commented Feb 3, 2018

@ojarjur Sorry for the late response, but I finally tried it out, and indeed, it seems to be a problem with the --container flag. If I don't use it I can ssh in there just fine. I'll file a bug as you suggested. Thanks!

As a reference, the bug report can be found here: https://issuetracker.google.com/issues/72889463

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants