This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Add some basic version information reporting: #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add the version of the Cloud SDK and datalab component used to create an instance to that instance's metadata. 2. When connecting to an instance using the `--diagnose-me` flag, report the version info from that instance's metadata entries.
chmeyers
approved these changes
Feb 13, 2018
| 'Cloud SDK component versions:' | ||
| '\n\tCloud SDK: {}' | ||
| '\n\tDatalab: {}'.format( | ||
| instance, sdk_version, datalab_version)) |
There was a problem hiding this comment.
Should we also print the current datalab/gcloud version, to help diagnose whether connect problems are due to a bad local version?
There was a problem hiding this comment.
That's already done in the datalab.py file.
An example output of running datalab connect --diagnose-me ... is:
Running with diagnostic messages enabled
Using the command "gcloud" to invoke gcloud
The installed gcloud version is:
Cloud SDK: 188.0.0
Datalab: 20180119
Instance ... was created with the following Cloud SDK component versions:
Cloud SDK: 188.0.0
Datalab: 20180119
Connecting to ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create an instance to that instance's metadata.
--diagnose-meflag,report the version info from that instance's metadata entries.