This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Retry integration tests on any exception. #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of this logic retried a test if any of its `self.assert...` calls failed. However, that does not handle the case where a nested call to `datalab` fails. In those cases a `CalledProcessError` would be raised. To retry on those scenarios as well, we extend the retry logic to retry on any instance of the `Exception` class.
yebrahim
approved these changes
Jun 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of this logic retried a test if any of its
self.assert...calls failed.However, that does not handle the case where a nested call to
datalabfails. In those cases aCalledProcessErrorwould beraised.
To retry on those scenarios as well, we extend the retry logic
to retry on any instance of the
Exceptionclass.