This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Support the new BigQuery types in charts #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigQuery's new Standard SQL support adds additional data [types](https://cloud.google.com/bigquery/sql-reference/data-types) that might occur in the schema field of results. These new types meant that we would get key errors when looking up the corresponding type to use for charting the data. Some of those new types correspond to the set of types supported by [Google Charts](https://developers.google.com/chart/interactive/docs/reference#DataTable_addColumn) and some do not. For the new types that have a correspondence we add that mapping to the code. For any other types, we simply map them to 'string' (to avoid a key error).
qimingj
approved these changes
Oct 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigQuery's new Standard SQL support adds additional data types that might occur in the schema field of results.
These new types meant that we would get key errors when looking up the corresponding type to use for charting the data.
Some of those new types correspond to the set of types supported by Google Charts and some do not.
For the new types that have a correspondence we add that mapping to the code. For any other types, we simply map them to 'string' (to avoid a key error).