-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialEq for all write types? #532
Comments
Yea, I think this makes sense. Do we also want to add Ord/Hash? |
if we add them all then I can delete some codegen code, and there isn't a ton of downside; maybe slightly slower compilation, but the compiled code should get stripped if it's unused |
I'm going to go ahead and try that, I think it'll save us future headaches. |
I don't find it as obvious that Ord and Hash make sense for everything? |
They're necessary if we ever want to put any of these types in a set. Overall none of these traits are 'always necessary', but we don't have perfect foresight of when they will be necessary, and the alternative (some ability to add them as needed in codegen) is more complicated and more work overall. |
It would be helpful for the compiler to be able to check if an instance of a write type changed using == but the types don't consistently implement partialeq. Maybe write-types should just always have Capability::Equality?
Context googlefonts/fontc#359 (comment)
The text was updated successfully, but these errors were encountered: