Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match fontmake glyph names #248

Open
rsheeter opened this issue Apr 10, 2023 · 5 comments
Open

Match fontmake glyph names #248

rsheeter opened this issue Apr 10, 2023 · 5 comments

Comments

@rsheeter
Copy link
Contributor

Currently the diff for fontmake Oswald vs fontmake-rs Oswald is very noisy due to differing glyph names. Fix it, or update the instructions (on milestone) to avoid.

LHS fontmake, RHS fontmake-rs

image

@rsheeter
Copy link
Contributor Author

#250 (comment) notes

The difference in glyph names is because in python fontmake the glyph names are renamed to final, "production" name (following AGLFN conventions), this is done in the ufo2ft postProcessor based on a number of conditions (e.g. presence of public.postscriptNames, if I remember the name of the lib key correctly, typing from memory) and options. It is done as a post-processing step because the feature file is supposed to contain source glyph names.

@rsheeter
Copy link
Contributor Author

--no-production-names resolves this for the purpose of comparing compiles. Removing from the milestone but leaving open in case we do want to support this form of renaming.

@RickyDaMa
Copy link
Contributor

Now that #489 has been merged, initial postscript name support is in for UFO sources

Main points that need to be addressed still to close this issue:

  • glyphs2ir support for postscript names
  • matching fontmake's name generation

@anthrotype
Copy link
Member

glyphs2ir support for postscript names

oh right I forgot that.. Then #498 too hastily got rid of the --no-production-names option. I think we want to continue passing --no-production-names flags to both fontc and fontmake in ttx_diff.py, until that is implemented for both DS and glyphs inputs. I'll make another PR

@anthrotype
Copy link
Member

matching fontmake's name generation

implementing the full ufo2ft postProcessor glyph-renaming logic is lower priority in my opinion, I think for now we can content ourselves to writing the explicit postscriptNames which are already there in the UFOs (and the ones generated from GlyphData.xml for .glyphs inputs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants