Model kerning in IR and capture it for .glyphs and .designspace #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Jun 8, 2023
anthrotype
reviewed
Jun 8, 2023
anthrotype
reviewed
Jun 8, 2023
cmyr
reviewed
Jun 8, 2023
rsheeter
force-pushed
the
kern3
branch
2 times, most recently
from
9786482
to
f5facab
Compare
anthrotype
reviewed
Jun 9, 2023
anthrotype
reviewed
Jun 9, 2023
anthrotype
reviewed
Jun 9, 2023
Closed
anthrotype
reviewed
Jun 13, 2023
anthrotype
reviewed
Jun 13, 2023
anthrotype
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent is to output variable features we compile with fea-rs. IR model is meant to accomodate glyphs and designspace. Most interesting part should be
fontir/src/ir.rswhich has the IR changes, esp.struct Kerningwhich holds a variable-first representation of kerning.left/right KerningGroup all the things. Or kern left/right ... it's all very confusing.
https://gist.github.com/rsheeter/4c8e7822d276f871eef974f8c1975ace shows an example of kerning IR (for Oswald).
Step toward #308. I want to leave filling in the blanks and aligning kerning groups to a subsequent PR.