Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: ufo2ft 2.25.0 rejects extra keyword arguments passed by fontmake #817

Closed
rschiang opened this issue Oct 18, 2021 · 2 comments
Closed

Regression: ufo2ft 2.25.0 rejects extra keyword arguments passed by fontmake #817

rschiang opened this issue Oct 18, 2021 · 2 comments

Comments

@rschiang
Copy link

rschiang commented Oct 18, 2021 •
edited

Starting from ufo2ft==2.25.0, the library will start to reject any unexpected arguments (googlefonts/ufo2ft@c87320c).

The current version of font_project.make_variable_font(), however, passes two of the arguments (flattenComponents, cubicConversionError) that are only meant to be used with ufo2ft.compileTTF but not ufo2ft.compileVariableTTF.

We’ll need to either prune the excess arguments or update ufo2ft to accept them.
@rschiang rschiang changed the title Extra kwargs in fontmake caused regression with ufo2ft 2.25.0 Regression: ufo2ft 2.25.0 rejects extra keyword arguments passed by fontmake Oct 18, 2021
@anthrotype
Copy link
Member

Sorry yes, thanks. Ufo2ft needs to continue accepting the arguments, I'll fix it.

Upstream issue is googlefonts/ufo2ft#551

anthrotype added a commit to googlefonts/ufo2ft that referenced this issue Oct 18, 2021
@anthrotype
fix regression in compileVariableTTF with valid kwargs
0d6caaa 
Fixes #551 and googlefonts/fontmake#817
@anthrotype
Copy link
Member

bumped minimum ufo2ft to 2.25.1 in 61b0641 -- which should fix this among other things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rschiang @anthrotype