Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "disabled" feature prefix code #761

Open
simoncozens opened this issue Jan 6, 2022 · 0 comments · May be fixed by #762
Open

Support "disabled" feature prefix code #761

simoncozens opened this issue Jan 6, 2022 · 0 comments · May be fixed by #762

Comments

@simoncozens
Copy link
Collaborator

Glyphs allows parts of the feature file to be disabled; glyphs2ufo ignores this setting and copies them to the features.fea anyway, with the result that:

featurePrefixes = (
{
code = "lookup IDontCare { sub nonsuchglyph by nonsuchglyph; } IDontCare;";
disabled = 1;
name = disabled;
}
);

produces a features.fea:

# Prefix: disabled
lookup IDontCare { sub nonsuchglyph by nonsuchglyph; } IDontCare;

When the feature is disabled because glyphs have been removed, this can cause the font to fail to build. (Also it's just wrong to include feature code that the designer has asked to be excluded.)

@simoncozens simoncozens linked a pull request Jan 6, 2022 that will close this issue
@simoncozens simoncozens changed the title Support "disabled" feature code Support "disabled" feature prefix code Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant