Don't write disabled feature prefixes #762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose that this will not roundtrip when ufo2glyphs, am I right? How important that would be? |
|
I think we already have that situation with disabled features. |
|
actually we seem to have code to parse that special comment, see Could you add a test to see if that also works for featurePrefixes? |
|
And don’t forget the classes. They can be disabled, too. |
belluzj
reviewed
Jan 12, 2022
| # Not even feature code | ||
|
|
||
| """ | ||
| ) |
There was a problem hiding this comment.
Could you check that when going back to Glyphs.app the commented-out feature prefix comes back uncommented? = in the same situation before going to UFO (if that sounds like a reasonable thing to have)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761.