Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our own exemplar parser #145

Merged
merged 2 commits into from
May 1, 2024
Merged

Our own exemplar parser #145

merged 2 commits into from
May 1, 2024

Conversation

simoncozens
Copy link
Contributor

  • Add our own parse function for exemplars
  • Tests for exemplar parser

@simoncozens simoncozens merged commit d8bccf8 into main May 1, 2024
6 checks passed
@simoncozens simoncozens deleted the our-own-parse branch May 1, 2024 09:38
@moyogo
Copy link
Contributor

moyogo commented May 1, 2024

@simoncozens Two things:

  • the function should also handle ranges
  • if you're going to copy and paste my code (which doesn't handle ranges) you should add me as a commiter or say so in the commit ;-)

@simoncozens
Copy link
Contributor Author

Sorry, you're right about the second thing. I'll fix that now. For the first, do we have ranges anywhere?

@moyogo
Copy link
Contributor

moyogo commented May 3, 2024

@simoncozens Yes, CJK for example, like in data/languages/zh_Hans.textproto where 万-与 is a range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants