Python3 port #267
Merged
Python3 port #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm this builds NotoColorEmoji.ttf fine! As mentioned, currently this depends on this specific nototools branch. Lets push for that to be merged before merging this? |
anthrotype
requested changes
Oct 15, 2019
|
@mike-fabian hey! thanks again for patch. I'll merge and apply the fix-ups myself |
anthrotype
force-pushed
the
python3-port
branch
from
78c5873
to
60161a3
Compare
anthrotype
requested review from
anthrotype and
RoelN
and removed request for
anthrotype
anthrotype
approved these changes
Oct 21, 2019
|
Cosimo Lupo <notifications@github.com> さんは書きました:
@mike-fabian hey! thanks again for patch. I'll merge and apply the fix-ups myself
Thank you!
…--
📧 Mike FABIAN <mike.fabian@gmx.de>
睡眠不足はいい仕事の敵だ。
|
|
Code looks good, font is being built without a hitch. 👍 |
RoelN
approved these changes
Oct 22, 2019
|
Hi! It would help Debian switch their nototools from python2 to python3 if someone would also port https://github.com/googlefonts/robotoslab |
|
@jbicha I wasn't aware that project relies on python2-only code. Can you please open an issue over there pointing to the files that need update? Thanks |
|
@anthrotype Never mind. You're right. It was just a copy-and-paste mistake in the Debian packaging for robotoslab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with the python3 port of nototools
notofonts/nototools#488
This pull request makes it possible to build the font using Python3.
Using Python2 still works as well, the code works with both.