Fix explicit attrib defaults being overridden by inherited values #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
added a commit
to anthrotype/noto-emoji
that referenced
this pull request
Dec 14, 2021
anthrotype
force-pushed
the
fix-inherited-defaults-issue-224
branch
from
653b4dd
to
5f85fe1
Compare
the rectangle must be black, not red
rsheeter
reviewed
Dec 14, 2021
| @@ -1320,11 +1333,25 @@ def _swap_elements(swaps: Iterable[Tuple[etree.Element, Sequence[etree.Element]] | |||
| raise ValueError("Lost parent!") | |||
| parent.remove(old_el) | |||
|
|
|||
| @lru_cache(maxsize=None) | |||
There was a problem hiding this comment.
Isn't the unbounded cache dangerous?
There was a problem hiding this comment.
I don't think so, because I always call cache_clear() at the beginning of _update_etree()
https://github.com/googlefonts/picosvg/pull/258/files#diff-613582736f235e34aeab2643a59d44fb26bfa66e5bcba5f4c6fa195d74b0e7b9R1349
functools.lru_cache(None) is the same as functools.cache(), but the latter is only available for 3.9+
https://docs.python.org/3/library/functools.html#functools.cache
rsheeter
reviewed
Dec 14, 2021
rsheeter
approved these changes
Dec 14, 2021
sido378
pushed a commit
to sido378/noto-emoji
that referenced
this pull request
Jul 7, 2022
sido378
pushed a commit
to sido378/noto-emoji
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224 and #257