Don't crash when there are only base-mark kerns #569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ufo2ft's kernFeatureWriter splits base-to-base and mark-to-base kerns like this:
ufo2ft/Lib/ufo2ft/featureWriters/kernFeatureWriter.py
Lines 449 to 452 in db8302b
There's a horrible corner case (which I've just hit!) if the only kerns in the font are between bases and marks:
basePairs
is empty and the assertion here fails:ufo2ft/Lib/ufo2ft/featureWriters/kernFeatureWriter.py
Lines 371 to 374 in db8302b
This fixes that.