Add static method PostProcessor.rename_glyphs #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Mar 16, 2022
|
make sure you do your renaming as first thing after loading a TTFont before loading any other table otherwise you incur in #485 |
|
Thanks for the tip! If you're happy, I'll squash the two commits. |
|
sure! LGTM |
m4rc1e
changed the title
|
hold up. I'm arse clowning here. |
|
oops merged :) |
anthrotype
reviewed
Mar 16, 2022
| @@ -155,7 +155,7 @@ def process_glyph_names(self, useProductionNames=None): | |||
|
|
|||
| if useProductionNames: | |||
| logger.info("Renaming glyphs to final production names") | |||
| self._rename_glyphs_from_ufo() | |||
| self.rename_glyphs(self.otf, self._build_production_names()) | |||
There was a problem hiding this comment.
I think we want to keep this line as it was before
self._rename_glyphs_from_ufo()
There was a problem hiding this comment.
Yep that was my arse clowing. Give me a sec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to rename glyphs in a ttf using a custom mapping. I don't really want to write my own function to do this since we're already doing it in this repo quite nicely.
No offence taken if this gets rejected.