disable COLR layer reuse for interpolatable masters when building variable fonts #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
well, not any more, my merging algorithm got cleverer, see fonttools/fonttools@e502980 However, disabling layer reuse when building master COLRs still makes sense from efficiency POW so it's still good to have the option to turn it off |
…iable fonts To successfully merge multiple master COLR tables into a variable COLR with varLib (fonttools/fonttools#2660) the master must have the same structure, number of color glyphs, total number of paints, etc. So we want to disable layer reuse optimization performed by fontTools.colorLib.buildCOLR when building each interpolatable COLR masters (otherwise we might end up with different PaintColrLayers or LayerList count between masters). I also added a colrLayerReuse parameter to compile* methods to force disabling this altogether, in case it might be useful for debugging or speeding up builds. This is set to True by default for all compile* methods, except for compileInterpolatable* Requires fonttools/fonttools#2660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To successfully merge multiple master COLR tables into a variable COLR with varLib (fonttools/fonttools#2660) the master must have the same structure,
number of color glyphs, total number of paints, etc. So we want to disable layer reuse optimization performed byfontTools.colorLib.buildCOLRwhen building each interpolatable COLR masters (otherwise we might end up with different PaintColrLayers or LayerList count between masters).I also added a
colrLayerReuseparameter to compile* methods to force disabling this altogether, in case it might be useful for debugging or speeding up builds.This is set to True by default for all compile* methods, except for compileInterpolatable*
Requires fonttools/fonttools#2660