Add feaIncludeDir option to allow override the include search path #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to fix googlefonts/glyphsLib#797, by allowing fontmake to override the default include directory used for parsing a UFO features.fea; useful when the UFOs where generated from a .glyphs source whose features contain some `include` statements and they are saved in a different directory (or not saved to disk at all). fontmake will need to be modified to call ufo2ft with this new option when starting to build from a .glyphs input.
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Jul 22, 2022
…irectory when building from Glyphs Fixes googlefonts/glyphsLib#797 Requires googlefonts/ufo2ft#637
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Jul 28, 2022
…irectory when building from Glyphs Fixes googlefonts/glyphsLib#797 Requires googlefonts/ufo2ft#637
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Oct 28, 2022
…irectory when building from Glyphs Fixes googlefonts/glyphsLib#797 Requires googlefonts/ufo2ft#637
anthrotype
added a commit
to googlefonts/fontmake
that referenced
this pull request
Oct 28, 2022
…irectory when building from Glyphs Fixes googlefonts/glyphsLib#797 Requires googlefonts/ufo2ft#637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix googlefonts/glyphsLib#797, by allowing fontmake to override the default include directory used for parsing a UFO features.fea; useful when the UFOs were generated from a .glyphs source whose features contain some
includestatements and they are saved in a different directory (or not saved to disk at all).fontmake will need to be modified to call ufo2ft with this new option when starting to build from a .glyphs input.