New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FlattenComponents] Don't throw weird errors when components are missing #669

Merged

simoncozens merged 3 commits into main from flatten-component-error

Oct 21, 2022

Contributor

simoncozens commented Oct 17, 2022

If I use fontmake on a Glyphs file which contains components with missing base glyphs, I get errors like this:

INFO:ufo2ft.filters:Running FlattenComponentsFilter on GoogleSans_Persian-Regular
fontmake: Error: In 'master_ufo/XXX-Regular.designspace': Generating fonts from Designspace failed: 'flig2'

(Side note: there are many cases where fontmake eats the original exception like this, and produces weird and inscrutable errors. We should hunt down all of them.)

With this PR, the font compiles with warnings:

WARNING:ufo2ft.filters.flattenComponents:Could not find component 'flig2' used in 'f_f'


          Don't throw weird errors when components are missing

a840cfb

Contributor Author

simoncozens commented Oct 17, 2022 •

edited

A second side note is that this happens even in glyphs which are set to non-exporting, which shouldn't happen anyway.

Member

anthrotype commented Oct 17, 2022

Are we sure a WARNING is better than a (probably better phrased) error in this case? A missing component is probably bad and should be caught at build time. Warnings can be ignored.

this happens even in glyphs which are set to non-exporting, which shouldn't happen anyway.

this should be investigated further, because I think preprocessor already takes care of excluding the non-exported glyphs from the glyph set that is passed to the filters, so FlattenComponentsFilter should not even see those..

Contributor Author

simoncozens commented Oct 17, 2022

Nope, I'm wrong - I was changing the exported glyphs of a Glyphs file but compiling the intermediate UFO. The glyphset issue is fine, so I'm happy to make this a hard error.


          Raise error instead of warning

4c4e8e3

anthrotype approved these changes

View reviewed changes

anthrotype reviewed

View reviewed changes

Lib/ufo2ft/filters/flattenComponents.py Outdated

                   """Returns a list of tuples (baseGlyph, transform) of nested component."""
+                  if component.baseGlyph not in glyphSet:
+                      raise ValueError(
+                          "Could not find component '%s' used in '%s'"

Member

anthrotype Oct 18, 2022

nit: use f"" string interpolation instead old-style %


          Format string nit

41cbb97

simoncozens merged commit 71ef6ca into main

khaledhosny deleted the flatten-component-error branch

November 18, 2022 13:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment