avoid reloading font unconditionally in postProcessor #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #485 For the tests to pass we need to release fonttools with fonttools/fonttools#2860
anthrotype
force-pushed
the
no-reload-font
branch
from
87e6efd
to
f79b160
Compare
|
I hope this will also fix another issue related to building fonts with huge glyph set like Source Han Sans, in which compiling post format 2 raises overflow error, but the compilation step is unnecessary and can be delayed at the very end after the postcript glyph names have been dropped (post format 3), like I do in this PR. #462 (comment) /cc @punchcutter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485
For the tests to pass we need to release fonttools with fonttools/fonttools#2860