Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split mark and base kerning pairs #713

Merged
merged 2 commits into from Mar 2, 2023
Merged

Split mark and base kerning pairs #713

merged 2 commits into from Mar 2, 2023

Conversation

madig
Copy link
Collaborator

@madig madig commented Feb 28, 2023

Split kerning pairs of bases against marks into

  1. base-to-base only pairs, for the base lookup
  2. mark-to-base, base-to-mark and mark-to-mark pairs, for the marks lookup

which should preserve the semantics of kerning exceptions (pairs modifying the effect of other pairs).

Closes #706.

Validated with https://github.com/daltonmaag/kerning-validator/tree/16927fc10b1f4d83d0f2b029b4c1b16a8d5c7efe. It fixes the problems in Noto Serif Tamil.

@madig madig force-pushed the split-mark-base-kerns branch 2 times, most recently from d3f825c to 8419d93 Compare February 28, 2023 17:08
@madig madig marked this pull request as ready for review February 28, 2023 17:08
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anthrotype anthrotype merged commit 28157d4 into main Mar 2, 2023
@anthrotype anthrotype deleted the split-mark-base-kerns branch March 2, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully 'base' kerning exceptions do not apply correctly to groups containing 'marks'
2 participants