Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on questionable (dis)use of # Automatic Code #719

Merged
merged 8 commits into from Mar 10, 2023

Conversation

madig
Copy link
Collaborator

@madig madig commented Mar 1, 2023

  1. Warn about mis-cased # Automatic Code comments (see Allow any casing of "# Automatic Code"? #701)
  2. Warn if there is no insertion marker but kerning.plist data and a manual kern/dist feature in the fea code (because kerning.plist will be dropped)

@anthrotype
Copy link
Member

@madig are you going to finish this? i'd like to cut a release soon-ish

@madig
Copy link
Collaborator Author

madig commented Mar 6, 2023

Yes, one day. Currently looking at something else but hopefully this week.

@madig madig force-pushed the warn-on-questionable-automatic-code branch 3 times, most recently from 39b9edc to 1a113f3 Compare March 8, 2023 16:02
@madig madig marked this pull request as ready for review March 8, 2023 16:02
@madig madig force-pushed the warn-on-questionable-automatic-code branch from 1a113f3 to 988033f Compare March 8, 2023 19:04
@madig madig requested a review from anthrotype March 8, 2023 19:06
Lib/ufo2ft/util.py Outdated Show resolved Hide resolved
Lib/ufo2ft/util.py Outdated Show resolved Hide resolved
@madig madig merged commit 5b22f20 into main Mar 10, 2023
@madig madig deleted the warn-on-questionable-automatic-code branch March 10, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants