Respect overrides due to openTypeNameRecords for the predefined name IDs #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Mar 8, 2023
anthrotype
reviewed
Mar 8, 2023
|
@anthrotype, added a test. Please take a look. |
|
the "tests/data/TestFont.ufo" file might be used in other tests, maybe it's preferable to not change that one, but perhaps you load it as is, add the custom openTypeNameRecords to the lib and the pass it on to the OutlineCompiler for testing? |
|
Yes, you are right. Created a separate file. |
anthrotype
reviewed
Mar 8, 2023
|
Sorry. Did not notice yesterday that the linter was complaining. Should be good now. |
anthrotype
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #726.