Move PodHostName to Beta (#3118)

Move PodHostName to Beta Co-authored-by: Zach Loafman <zml@google.com>
googleforgames · Apr 26, 2023 · d436374 · d436374
1 parent 0248d87
commit d436374
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 6 deletions.
diff --git a/build/Makefile b/build/Makefile
@@ -64,7 +64,7 @@ KIND_CONTAINER_NAME=$(KIND_PROFILE)-control-plane
 GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
 
 # Enable all alpha feature gates. Keep in sync with `false` (alpha) entries in pkg/util/runtime/features.go:featureDefaults
-ALPHA_FEATURE_GATES ?= "PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=true&SplitControllerAndExtensions=true&CountsAndLists=true&FleetAllocationOverflow=true&Example=true"
+ALPHA_FEATURE_GATES ?= "PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&SplitControllerAndExtensions=true&CountsAndLists=true&FleetAllocationOverflow=true&Example=true"
 
 # Build with Windows support
 WITH_WINDOWS=1

diff --git a/cloudbuild.yaml b/cloudbuild.yaml
@@ -314,12 +314,12 @@ steps:
           region=${versionsAndRegions[$version]}
           if [ $cloudProduct = generic ]
           then
-            featureWithGate="CustomFasSyncInterval=false&SafeToEvict=false&SDKGracefulTermination=false&StateAllocationFilter=false&PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=true&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&Example=true"
+            featureWithGate="CustomFasSyncInterval=false&SafeToEvict=false&SDKGracefulTermination=false&StateAllocationFilter=false&PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=false&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&Example=true"
             featureWithoutGate=""
             testClusterLocation="${region}-c"
             testCluster="gke-standard-e2e-test-cluster-${version//./-}"
           else
-            featureWithGate="CustomFasSyncInterval=false&SafeToEvict=true&SDKGracefulTermination=false&StateAllocationFilter=false&PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=true&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&Example=true"
+            featureWithGate="CustomFasSyncInterval=false&SafeToEvict=true&SDKGracefulTermination=false&StateAllocationFilter=false&PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&PodHostname=false&SplitControllerAndExtensions=true&FleetAllocationOverflow=true&Example=true"
             featureWithoutGate="SplitControllerAndExtensions=true"
             testClusterLocation="${region}"
             testCluster="gke-autopilot-e2e-test-cluster-${version//./-}"

diff --git a/install/helm/agones/defaultfeaturegates.yaml b/install/helm/agones/defaultfeaturegates.yaml
@@ -19,12 +19,12 @@ CustomFasSyncInterval: true
 SafeToEvict: true
 SDKGracefulTermination: true
 StateAllocationFilter: true
+PodHostname: true
 
 # Alpha features
 PlayerAllocationFilter: false
 PlayerTracking: false
 ResetMetricsOnDelete: false
-PodHostname: false
 FleetAllocationOverflow: false
 SplitControllerAndExtensions: false
 

diff --git a/pkg/util/runtime/features.go b/pkg/util/runtime/features.go
@@ -113,12 +113,12 @@ var (
 		FeatureSafeToEvict:            true,
 		FeatureSDKGracefulTermination: true,
 		FeatureStateAllocationFilter:  true,
+		FeaturePodHostname:            true,
 
 		// Alpha features
 		FeaturePlayerAllocationFilter:       false,
 		FeaturePlayerTracking:               false,
 		FeatureResetMetricsOnDelete:         false,
-		FeaturePodHostname:                  false,
 		FeatureFleetAllocateOverflow:        false,
 		FeatureSplitControllerAndExtensions: false,
 

diff --git a/site/content/en/docs/Guides/feature-stages.md b/site/content/en/docs/Guides/feature-stages.md
@@ -24,6 +24,7 @@ that can be found in the [Helm configuration]({{< ref "/docs/Installation/Instal
 
 The current set of `alpha` and `beta` feature gates:
 
+{{% feature expiryVersion="1.32.0" %}}
 | Feature Name                                                                                                          | Gate                           | Default  | Stage   | Since  |
 |-----------------------------------------------------------------------------------------------------------------------|--------------------------------|----------|---------|--------|
 | [Custom resync period for FleetAutoscaler](https://github.com/googleforgames/agones/issues/1955)                      | `CustomFasSyncInterval`        | Enabled  | `Beta`  | 1.25.0 |
@@ -43,6 +44,29 @@ If you aren't sure if Feature Flags have been set correctly, have a look at the
 _[The Feature Flag I enabled/disabled isn't working as expected]({{% relref "troubleshooting.md#the-feature-flag-i-enableddisabled-isnt-working-as-expected" %}})_
 troubleshooting section.
 {{< /alert >}}
+{{% /feature %}}
+
+{{% feature publishVersion="1.32.0" %}}
+| Feature Name                                                                                                          | Gate                           | Default  | Stage   | Since  |
+|-----------------------------------------------------------------------------------------------------------------------|--------------------------------|----------|---------|--------|
+| [Custom resync period for FleetAutoscaler](https://github.com/googleforgames/agones/issues/1955)                      | `CustomFasSyncInterval`        | Enabled  | `Beta`  | 1.25.0 |
+| [GameServer Stable Network ID]({{% ref "/docs/Reference/gameserver.md#stable-network-id" %}})                         | `PodHostname`                  | Enabled | `Beta` | 1.32.0 |
+| [GameServer `eviction` API](https://github.com/googleforgames/agones/issues/2794)                                     | `SafeToEvict`                  | Enabled  | `Beta`  | 1.30.0 |
+| [Graceful Termination for GameServer SDK](https://github.com/googleforgames/agones/pull/2205)                         | `SDKGracefulTermination`       | Enabled  | `Beta`  | 1.18.0 |
+| [GameServer state filtering on GameServerAllocations](https://github.com/googleforgames/agones/issues/1239)           | `StateAllocationFilter`        | Enabled  | `Beta`  | 1.26.0 |
+| [GameServer player capacity filtering on GameServerAllocations](https://github.com/googleforgames/agones/issues/1239) | `PlayerAllocationFilter`       | Disabled | `Alpha` | 1.14.0 |
+| [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}})                                                      | `PlayerTracking`               | Disabled | `Alpha` | 1.6.0  |
+| [Reset Metric Export on Fleet / Autoscaler deletion]({{% relref "./metrics.md#dropping-metric-labels" %}})            | `ResetMetricsOnDelete`         | Disabled | `Alpha` | 1.26.0 |
+| [Split `agones-controller` ](https://github.com/googleforgames/agones/issues/2797)                                    | `SplitControllerAndExtensions` | Disabled | `Alpha` | 1.30.0 |
+| [Allocated GameServers are notified on relevant Fleet Updates](https://github.com/googleforgames/agones/issues/2682)  | `FleetAllocationOverflow`      | Disabled | `Alpha` | 1.30.0 |
+| Example Gate (not in use)                                                                                             | `Example`                      | Disabled | None    | 0.13.0 |
+
+{{< alert title="Note" color="info" >}}
+If you aren't sure if Feature Flags have been set correctly, have a look at the 
+_[The Feature Flag I enabled/disabled isn't working as expected]({{% relref "troubleshooting.md#the-feature-flag-i-enableddisabled-isnt-working-as-expected" %}})_
+troubleshooting section.
+{{< /alert >}}
+{{% /feature %}}
 
 ## Description of Stages
 

diff --git a/site/content/en/docs/Reference/gameserver.md b/site/content/en/docs/Reference/gameserver.md
@@ -133,7 +133,7 @@ The GameServer resource does not support updates. If you need to make regular up
 
 ## Stable Network ID
 
-{{< alpha title="Stable Network ID" gate="PodHostname" >}}
+{{< beta title="Stable Network ID" gate="PodHostname" >}}
 
 If you want to connect to a `GameServer` from within your Kubernetes cluster via a convention based
 DNS entry, each Pod attached to a `GameServer` automatically derives its hostname from the name of the `GameServer`.