TCPUDP not supported

[stpnov]

What happened:

Pod "gameserver" is invalid: spec.containers[0].ports[0].protocol: Unsupported value: "TCPUDP": supported values: "SCTP", "TCP", "UDP"

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

apiVersion: agones.dev/v1
kind: GameServer
spec:
  ports:
     portPolicy: Static
     containerPort: 7000
     hostPort: 7000
     protocol: TCPUDP

Anything else we need to know?:

Environment:

• Agones version: v1.18.0
• Kubernetes version (use kubectl version): v1.22.1
• Install method (yaml/helm): helm

[markmandel]

🤔 I wonder if we don't catch the condition in a Static config.

Can you try a dynamic port config?

[stpnov]

Everything works fine with dynamic port

[roberthbailey]

#1764 only updated the code path where we assign a port to the game server.

[markmandel]

This looks to be the magic line of concern:

agones/pkg/gameservers/portallocator.go

Lines 155 to 157 in 06ae7a8

	if p.PortPolicy != agonesv1.Dynamic && p.PortPolicy != agonesv1.Passthrough {
	continue
	}

Reference for GameServer - see ports section:
https://agones.dev/site/docs/reference/gameserver/

[markmandel]

On review with @SaitejaTamma , really we should move the custom logic from portallocator.go to

agones/pkg/apis/agones/v1/gameserver.go

Lines 594 to 599 in 9fa432c

	for _, p := range gs.Spec.Ports {
	cp := corev1.ContainerPort{
	ContainerPort: p.ContainerPort,
	HostPort: p.HostPort,
	Protocol: p.Protocol,
	}

Since GameServer.Pod(...) is the central place that handles the creation of a Pod's container ports.

[markmandel]

@ashutosji we tried this a long time ago - but if you're looking for a challenge, this could be for you.

This will require you to create a test cluster, build Agones, and have tests for it (go through https://github.com/googleforgames/agones/blob/main/build/README.md). Have a look and let me know if you would be willing to give this a shot.

[ashutosji]

Sure @markmandel! I will look into this.

[ashutosji]

This looks to be the magic line of concern:

agones/pkg/gameservers/portallocator.go

Lines 155 to 157 in 06ae7a8

	if p.PortPolicy != agonesv1.Dynamic && p.PortPolicy != agonesv1.Passthrough {
	continue
	}

Reference for GameServer - see ports section: https://agones.dev/site/docs/reference/gameserver/

isn't this piece of code is confusing? If the condition is valid then it should work for Static as well. Or else i can remove this case.
WDYT?

[markmandel]

The tricky part is:

agones/pkg/gameservers/controller.go

Line 460 in 06ae7a8

gsCopy := c.portAllocator.Allocate(gs.DeepCopy())

Doesn't get called, because for Static port, there is no allocation.

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[markmandel]

Currently being work on in #3375