Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build after make gen-all-sdk-grpc #3302

Closed
zmerlynn opened this issue Aug 1, 2023 · 3 comments · Fixed by #3301
Closed

Cannot build after make gen-all-sdk-grpc #3302

zmerlynn opened this issue Aug 1, 2023 · 3 comments · Fixed by #3301
Labels
kind/bug These are bugs.

Comments

@zmerlynn
Copy link
Collaborator

zmerlynn commented Aug 1, 2023

make gen-all-sdk-grpc on a clean repo currently produces a number of deltas and results in something that will not build - see #3301.

The first issue is actually in Node.js:


Error: Cannot find module './google/api/client_pb.js'
Require stack:
- /go/src/agones.dev/agones/sdks/nodejs/lib/alpha/alpha_pb.js
- /go/src/agones.dev/agones/sdks/nodejs/src/alpha.js
- /go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js
- /go/src/agones.dev/agones/sdks/nodejs/spec/agonesSDK.spec.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/go/src/agones.dev/agones/sdks/nodejs/lib/alpha/alpha_pb.js:35:28)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/go/src/agones.dev/agones/sdks/nodejs/lib/alpha/alpha_pb.js',
    '/go/src/agones.dev/agones/sdks/nodejs/src/alpha.js',
    '/go/src/agones.dev/agones/sdks/nodejs/src/agonesSDK.js',
    '/go/src/agones.dev/agones/sdks/nodejs/spec/agonesSDK.spec.js'
  ]
}
npm ERR! code 1
npm ERR! path /go/src/agones.dev/agones/sdks/nodejs
@zmerlynn zmerlynn added the kind/bug These are bugs. label Aug 1, 2023
@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 1, 2023

Got past the node.js issue with 5a46f20, we'll see what's next!

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 1, 2023

And now we're on to the error @igooch saw a while ago:

Step #26 - "sdk-conformance": error[E0433]: failed to resolve: could not find `prost_types` in the list of imported crates
Step #26 - "sdk-conformance":   --> /go/src/agones.dev/agones/test/sdk/rust/.cargo-targets/debug/build/agones-475a64c5db4b6b2a/out/agones.dev.sdk.alpha.rs:57:47
Step #26 - "sdk-conformance":    |
Step #26 - "sdk-conformance": 57 |     pub update_mask: ::core::option::Option<::prost_types::FieldMask>,
Step #26 - "sdk-conformance":    |                                               ^^^^^^^^^^^ could not find `prost_types` in the list of imported crates
Step #26 - "sdk-conformance": 
Step #26 - "sdk-conformance": error[E0433]: failed to resolve: could not find `prost_types` in the list of imported crates
Step #26 - "sdk-conformance":   --> /go/src/agones.dev/agones/test/sdk/rust/.cargo-targets/debug/build/agones-475a64c5db4b6b2a/out/agones.dev.sdk.alpha.rs:87:47
Step #26 - "sdk-conformance":    |
Step #26 - "sdk-conformance": 87 |     pub update_mask: ::core::option::Option<::prost_types::FieldMask>,
Step #26 - "sdk-conformance":    |                                               ^^^^^^^^^^^ could not find `prost_types` in the list of imported crates
Step #26 - "sdk-conformance": 
Step #26 - "sdk-conformance": For more information about this error, try `rustc --explain E0433`.

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 1, 2023

Which should be solved by 68b1fbf. What's next!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant