Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run make gen-all-sdk-grpc #3301

Merged
merged 3 commits into from Aug 1, 2023
Merged

Run make gen-all-sdk-grpc #3301

merged 3 commits into from Aug 1, 2023

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Aug 1, 2023 •
edited

Regenerate client SDK gRPCs, they are behind.

Fixes #3302

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dcc34a0e-0461-4c57-8437-0f15cb42c502

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn zmerlynn mentioned this pull request Aug 1, 2023
Closed
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9d4177ab-de66-4d4e-9056-2c2bae346d79

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c71ccd18-882f-414b-b38a-b7dba932a387

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f14e461b-4fea-430f-b7e8-c0c79fbefd40

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 151f44e8-1e33-4969-9f9c-279cc75c990b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@zmerlynn
Copy link
Collaborator Author

zmerlynn commented Aug 1, 2023

I'm hopeful on this!

@zmerlynn zmerlynn marked this pull request as ready for review August 1, 2023 18:33
@google-oss-prow google-oss-prow bot added the lgtm label Aug 1, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d3e7b66e-65d1-4b51-882b-aee9a8524402

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3301/head:pr_3301 && git checkout pr_3301
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-e349924-amd64

@zmerlynn zmerlynn merged commit 17b305d into googleforgames:main Aug 1, 2023
3 checks passed
@steven-supersolid
Copy link
Collaborator

Nice!

@zmerlynn zmerlynn mentioned this pull request Aug 2, 2023
Merged
@Kalaiselvi84 Kalaiselvi84 added kind/bug These are bugs. and removed kind/other labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@steven-supersolid steven-supersolid Awaiting requested review from steven-supersolid

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved kind/bug These are bugs. lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build after make gen-all-sdk-grpc
5 participants
@zmerlynn @agones-bot @steven-supersolid @markmandel @Kalaiselvi84