Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart parameters to tune sdk RBAC #438

Closed
Oleksii-Terekhov opened this issue Dec 3, 2018 · 4 comments
Closed

Helm chart parameters to tune sdk RBAC #438

Oleksii-Terekhov opened this issue Dec 3, 2018 · 4 comments
Labels
question I have a question!

Comments

@Oleksii-Terekhov
Copy link

Now: I tune helm chart install\helm\agones\templates\serviceaccounts\sdk.yaml to enable communicate between my sidecar and k8s, due this ClusterRole applied to all containers in mutation hook:

- apiGroups: [""]
  resources: ["pods"]
  verbs: ["list", "get"]

Proposal: allow additional tunes in helm or allow manual accounts tune for containers in gs

@markmandel markmandel added the question I have a question! label Dec 4, 2018
@markmandel
Copy link
Member

You can create your own service account for the SDK pod:
https://github.com/GoogleCloudPlatform/agones/blob/master/install/helm/README.md#configuration
via agones.serviceaccount.sdk, and use that instead.

Long term, we may manually only apply this just the sidecar, see #150 for some more details (or remove it from the GameServer process)

There could be possible options to manually mount secrets into your containers to allow a specific service account as well, if you want to go that experimental route.

Does that solve your problem?

@Oleksii-Terekhov
Copy link
Author

  • with own account - i still locked to agones: if you change rights in new release, i MUST change it too
  • with "only apply this just the sidecar" - looks good if i can tune RBAC for sidecar container via fleet or gs yaml

@markmandel
Copy link
Member

markmandel commented Dec 4, 2018

with own account - i still locked to agones: if you change rights in new release, i MUST change it too
I'm not

I'm not sure how we can provide values in values.yaml to extend something as complicated as RBAC permissions. Suggestions would be appreciated! (or PRs!) @Kuqd - do you have any ideas

I'm almost wondering if it's better if you update the RBAC permissions yourself after you install the helm chart.

with "only apply this just the sidecar" - looks good if i can tune RBAC for sidecar container via fleet or gs yaml

This would need to be done at the install time - we couldn't do this at runtime in the CRD.

But a GameServer has a full PodSpec - so you can specify your own container secrets (this probably needs research to see how well this works)

@Oleksii-Terekhov
Copy link
Author

OK
Close issue as may local trouble
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question I have a question!
Projects
None yet
Development

No branches or pull requests

2 participants