Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to opencensus v0.22 #892

Closed
pjayara-g opened this issue Jul 10, 2019 · 4 comments · Fixed by #1446
Closed

Update to opencensus v0.22 #892

pjayara-g opened this issue Jul 10, 2019 · 4 comments · Fixed by #1446
Assignees
@aLekSer
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Milestone
1.6.0

Comments

@pjayara-g
Copy link

This is from #831 . @markmandel suggested updating the version of opencensus. This bug is to track that.
@pjayara-g pjayara-g added the kind/feature New features for Agones label Jul 10, 2019
@pjayara-g pjayara-g mentioned this issue Jul 10, 2019
Closed
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! labels Sep 25, 2019
@markmandel
Copy link
Member

This still would be great - just need to split things in the commit -- you can see details in the #893 PR.

@markmandel
Copy link
Member

gRPC has been updated, so we can now do this work! 🔥

@aLekSer aLekSer self-assigned this Mar 25, 2020
@aLekSer
Copy link
Collaborator

aLekSer commented Mar 25, 2020 •
edited

This should fix the following error on allocation Metrics:
Failed to export to Prometheus: inconsistent label cardinality: expected 1 label values but got 0 in []string(nil)
#1330 (comment)
@akremsa Please also take a look on this

@aLekSer aLekSer mentioned this issue Apr 24, 2020
Merged
@aLekSer
Copy link
Collaborator

aLekSer commented Apr 24, 2020

We have updated OpenCensus to the most recent release:
https://github.com/census-instrumentation/opencensus-go/releases/tag/v0.22.3

@aLekSer aLekSer closed this as completed Apr 24, 2020
@markmandel markmandel added this to the 1.6.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aLekSer aLekSer

Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Update to OpenCensus version 0.22.3 aLekSer/agones
3 participants
@markmandel @aLekSer @pjayara-g