Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fieldalignment linter, then mostly ignore it #2795

Merged
merged 1 commit into from
Nov 9, 2022

Commits on Nov 9, 2022

  1. Enable fieldalignment linter, then mostly ignore it

    This enables the fieldalignment linter by enabling all `govet` checks
    except shadowing. I then configured it to ignore large swaths of code
    (tests, cmd/, APIs), and nolint'd all the existing complaints because
    they seemed irrelevant.
    
    Along the way:
    
    * removed existing nolint:maligned, as `maligned` is no more.
    
    * disabled `structcheck` and `deadcode` as they are deprecated (and I
    think have been subsumed by other linters?)
    
    * changed `gameServerCacheEntry` to `gameServerCache`. It is the
    cache, not just an entry.
    
    * fixed alignment of `gameServerSetCacheEntry`.
    
    Closes googleforgames#2325
    zmerlynn committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a8f6a43 View commit details
    Browse the repository at this point in the history