Fix parsing of empty matchobject fields by the redis PB marshaling/unmarshaling code

[joeholley]

This is a benign error (no effect on running OM) but it can be misleading and is pretty spammy :/

msg="invalid character '}' looking for beginning of value" app=openmatch caller=internal/statestorage/redis/redispb/redispb.go cmd=HGETALL component=statestorage key=a2be9dbd0cc04367a06c0f4bea46baea.testprofilev1

[ihrankouski]

These errors are coming from two places:

• https://github.com/GoogleCloudPlatform/open-match/blob/master/internal/statestorage/redis/redispb/redispb.go#L159
• https://github.com/GoogleCloudPlatform/open-match/blob/master/internal/statestorage/redis/redispb/redispb.go#L167

One case when errors happen there is when pbMap doesn't have a key: Sprintf'ed string will not be valid JSON then.

While working on this I noticed weird issue at first sight: Wrapping these places with error checks makes Backend API to start sending an empty MatchObject in a response to profile without "rosters" field set. After some debugging I think there's a bug in this same function that breaks Watcher:

• When Evaluator approves proposal it renames the key in Redis.
• To detect a fact of proposal approval the Backend's Watcher periodically calls UnmarshalFromRedis() which sends HGETALL under hood.
• According to Redis docs HGETALL returns empty list when key does not exist, and Redigo seem to not treat empty list as error. And this breaks the logic of Watcher's work since UnmarshalFromRedis() doesn't check for results' length. (It was working previously because of this "invalid character '}'" JSON bug which caused UnmarshalFromRedis() to return error making Watcher think that there's not results yet)