New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor e2e testing and improve coverage #1204
Conversation
Honestly speaking I am lost in the halfway doing the review... 😵 May need one more day to digest this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't went through the tests yet, will look into them later today.
/gcprun |
/gcbrun |
Looks like the test failed for some reason. Adding |
This PR refactors the testing so that the in memory and cluster tests share more logic. The om testing struct is also easier to use. All of the e2e test cases now run in the real cluster, instead of a single one.
Resolves #1188
(I chose to use sleeping without custom time code, because the custom time code got overly complex. Instead all sleeps are reduced to 100ms.)
Resolves #1169
Resolves #1052
Long list of random changes: