Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved app tests #1253

Merged
merged 1 commit into from Aug 31, 2020
Merged

Improved app tests #1253

merged 1 commit into from Aug 31, 2020

Conversation

akremsa
Copy link

@akremsa akremsa commented Aug 30, 2020 •
edited

What this PR does / Why we need it:
Switched from assert to require.
Also made output where we compare error codes more readable.

Current output:

Error:      	Not equal: 
            	expected: 0xa
            	actual  : 0xe

After the fix:

Error:      	Not equal: 
            	expected: "Aborted"
            	actual  : "NotFound"

aLekSer
aLekSer approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Laremere
Copy link

Nitpick: Switched from assert to require.

@Laremere Laremere merged commit 5f67bb3 into googleforgames:master Aug 31, 2020
@syntxerror syntxerror added this to the v1.1.0 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laremere Laremere Laremere approved these changes

@aLekSer aLekSer aLekSer approved these changes

Assignees
No one assigned
Labels
area/testing cla: yes
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akremsa @Laremere @aLekSer @googlebot @syntxerror @alexey-kremsa-globant