New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tests for statestore - redis #1264
Conversation
f187183
to
3d761bf
Compare
3d761bf
to
43849a9
Compare
@Laremere could you please take a look? |
ff4deae
to
319125e
Compare
test fix fix typo minor fix fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was already reasonably good coverage of this through the e2e tests (unfortunately coverage doesn't work across packages.) This seems like enough of a positive, and don't want to waste your work, so approving.
I think in the future if there are instances where these tests need to change and coverage is handled by e2e tests, I'll be fine with PR authors either fixing this test, or removing test cases here (again, as long as it's also covered well by e2e.)
Thanks for the PR! |
What this PR does / Why we need it:
I've noticed that redis.go has low unit test coverage and decided to improve that.
Before:
After: