Create, Update backfill after MMF run #1299
Conversation
| m := &pb.Match{ | ||
| MatchId: "1", | ||
| Tickets: []*pb.Ticket{t1}, | ||
| Backfill: b, |
There was a problem hiding this comment.
Please test the mmf changing a value on the backfill.
There was a problem hiding this comment.
I will check changes to search fields and extensions fields will be applied.
| client, err := om.Query().QueryTickets(ctx, &pb.QueryTicketsRequest{Pool: &pb.Pool{ | ||
| StringEqualsFilters: []*pb.StringEqualsFilter{{StringArg: "field", Value: "value"}}, | ||
| }}) | ||
|
|
There was a problem hiding this comment.
We're also going to want to include making sure the backfill updates in query. (having queried before so we know it has the old cached version.) This isn't going to work until several pieces are in place though... just make sure it's on the work items that get done. (either your tracker, or just an issue on github)
There was a problem hiding this comment.
You are talking about querying tickets or backfills? Using such code I just want to ensure that ticket associated with backfill will disappear from query results.
There was a problem hiding this comment.
Oh actually this just made me realize, when a backfill is rejected because of an update from the game server - we need to release the tickets because they were already marked as pending by the synchronizer. (or move the marking as pending to the backend after verifying the backfill would work too.)
I was talking about the backfill having a new field value set by the mmf.
There was a problem hiding this comment.
The work re: unpending tickets because a backfill changed, can be done in a followup PR.
|
From the CI failure: |
What this PR does / Why we need it:
Each time when MMF proposes a match with backfill, the backfill should be saved or updated in the store.